Module:TNT - Revision history

NMcLarty27: 33 revisions imported

2024-04-08T14:26:24Z

33 revisions imported

← Older revision	Revision as of 10:26, 8 April 2024
(No difference)

NMcLarty27: 1 revision imported

2023-12-25T23:22:57Z

1 revision imported

← Older revision		Revision as of 19:22, 25 December 2023
Line 50:		Line 50:
	id = mw.text.trim(v)		id = mw.text.trim(v)
	elseif type(k) == 'number' then		elseif type(k) == 'number' then
	params~~[k - 2] =~~ mw.text.trim(v)		table.insert(params, mw.text.trim(v))
	elseif k == 'lang' and v ~= '_' then		elseif k == 'lang' and v ~= '_' then
	lang = mw.text.trim(v)		lang = mw.text.trim(v)
Line 96:		Line 96:
	local data = loadData(dataset)		local data = loadData(dataset)
	local names = {}		local names = {}
	for _, field in ~~ipairs~~(data.schema.fields) do		for _, field in pairs(data.schema.fields) do
	table.insert(names, field.name)		table.insert(names, field.name)
	end		end

	~~local numOnly = true~~
	local params = {}		local params = {}
	local paramOrder = {}		local paramOrder = {}
	for _, row in ~~ipairs~~(data.data) do		for _, row in pairs(data.data) do
	local newVal = {}		local newVal = {}
	local name = nil		local name = nil
	for pos, ~~columnName~~ in ~~ipairs~~(~~names~~) do		for pos, val in pairs(row) do
			local columnName = names[pos]
	if columnName == 'name' then		if columnName == 'name' then
	name = ~~row[pos]~~		name = val
	else		else
	newVal[columnName] = ~~row[pos]~~		newVal[columnName] = val
	end		end
	end		end
	if name then		if name then
	~~if (~~
	~~(type(name) ~= "number")~~
	~~and (~~
	~~(type(name) ~= "string")~~
	~~or not string.match(name, "^%d+$")~~
	)
	~~) then~~
	~~numOnly = false~~
	~~end~~
	params[name] = newVal		params[name] = newVal
	table.insert(paramOrder, name)		table.insert(paramOrder, name)
Line 129:		Line 120:

	-- Work around json encoding treating {"1":{...}} as an [{...}]		-- Work around json encoding treating {"1":{...}} as an [{...}]
	~~if numOnly then~~		params['zzz123']=''
	params['zzz123']=''
	~~end~~

	local json = mw.text.jsonEncode({		local json = mw.text.jsonEncode({
	params=params,		params=params,
	paramOrder=paramOrder,		paramOrder=paramOrder,
	description=data.description,		description=data.description
	})		})

	~~if numOnly then~~		json = string.gsub(json,'"zzz123":"",?', "")
	json = string.gsub(json,'"zzz123":"",?', "")
	~~end~~

	return json		return json
Line 170:		Line 157:
	-- Give helpful error to thirdparties who try and copy this module.		-- Give helpful error to thirdparties who try and copy this module.
	if not mw.ext or not mw.ext.data or not mw.ext.data.get then		if not mw.ext or not mw.ext.data or not mw.ext.data.get then
	error(~~string.format([[''~~'Missing JsonConfig extension~~, or not properly configured~~;		error('Missing JsonConfig extension; Cannot load https://commons.wikimedia.org/wiki/Data:' .. dataset)
	Cannot load https://commons.wikimedia.org/wiki/Data:~~%s.~~
	~~See https://www~~.~~mediawiki~~.~~org/wiki/Extension:JsonConfig#Supporting_Wikimedia_templates''']],~~ dataset))
	end		end

en>ExE Boss: Only use the `zzz123` workaround for integer‑only parameter names

2023-02-02T01:14:59Z

Only use the `zzz123` workaround for integer‑only parameter names

← Older revision		Revision as of 21:14, 1 February 2023
Line 100:		Line 100:
	end		end

			local numOnly = true
	local params = {}		local params = {}
	local paramOrder = {}		local paramOrder = {}
Line 113:		Line 114:
	end		end
	if name then		if name then
			if (
			(type(name) ~= "number")
			and (
			(type(name) ~= "string")
			or not string.match(name, "^%d+$")
			)
			) then
			numOnly = false
			end
	params[name] = newVal		params[name] = newVal
	table.insert(paramOrder, name)		table.insert(paramOrder, name)
Line 119:		Line 129:

	-- Work around json encoding treating {"1":{...}} as an [{...}]		-- Work around json encoding treating {"1":{...}} as an [{...}]
	params['zzz123']=''		if numOnly then
			params['zzz123']=''
			end

	local json = mw.text.jsonEncode({		local json = mw.text.jsonEncode({
	params=params,		params=params,
	paramOrder=paramOrder,		paramOrder=paramOrder,
	description=data.description		description=data.description,
	})		})

	json = string.gsub(json,'"zzz123":"",?', "")		if numOnly then
			json = string.gsub(json,'"zzz123":"",?', "")
			end

	return json		return json

en>Ciencia Al Poder: Even more helpful error message

2022-01-17T10:51:03Z

Even more helpful error message

← Older revision		Revision as of 06:51, 17 January 2022
Line 156:		Line 156:
	-- Give helpful error to thirdparties who try and copy this module.		-- Give helpful error to thirdparties who try and copy this module.
	if not mw.ext or not mw.ext.data or not mw.ext.data.get then		if not mw.ext or not mw.ext.data or not mw.ext.data.get then
	error('Missing JsonConfig extension; Cannot load https://commons.wikimedia.org/wiki/Data:' .. dataset)		error(string.format([['''Missing JsonConfig extension, or not properly configured;
			Cannot load https://commons.wikimedia.org/wiki/Data:%s.
			See https://www.mediawiki.org/wiki/Extension:JsonConfig#Supporting_Wikimedia_templates''']], dataset))
	end		end

en>Yurik: Apply fix from user:ExE Boss - copying https://www.mediawiki.org/w/index.php?title=Module:TNT/sandbox&oldid=4692817

2021-07-06T16:44:32Z

Apply fix from user:ExE Boss - copying https://www.mediawiki.org/w/index.php?title=Module:TNT/sandbox&oldid=4692817

← Older revision		Revision as of 12:44, 6 July 2021
Line 105:		Line 105:
	local newVal = {}		local newVal = {}
	local name = nil		local name = nil
	for pos, ~~val~~ in ipairs(~~row~~) do		for pos, columnName in ipairs(names) do
	~~local columnName = names[pos]~~
	if columnName == 'name' then		if columnName == 'name' then
	name = ~~val~~		name = row[pos]
	else		else
	newVal[columnName] = ~~val~~		newVal[columnName] = row[pos]
	end		end
	end		end

en>Erutuon: insert positional parameters into params in the order of their keys, not the order in which pairs(frame.args) happens to encounter them

2021-06-09T17:31:32Z

insert positional parameters into params in the order of their keys, not the order in which pairs(frame.args) happens to encounter them

← Older revision		Revision as of 13:31, 9 June 2021
Line 50:		Line 50:
	id = mw.text.trim(v)		id = mw.text.trim(v)
	elseif type(k) == 'number' then		elseif type(k) == 'number' then
	~~table.insert(~~params, mw.text.trim(v))		params[k - 2] = mw.text.trim(v)
	elseif k == 'lang' and v ~= '_' then		elseif k == 'lang' and v ~= '_' then
	lang = mw.text.trim(v)		lang = mw.text.trim(v)

en>Erutuon: use ipairs to guarantee iteration over integer keys starting at 1 (pairs happens to iterate that way very often, but a case where it does not has been reported on the talk page)

2021-06-09T17:30:32Z

use ipairs to guarantee iteration over integer keys starting at 1 (pairs happens to iterate that way very often, but a case where it does not has been reported on the talk page)

← Older revision		Revision as of 13:30, 9 June 2021
Line 96:		Line 96:
	local data = loadData(dataset)		local data = loadData(dataset)
	local names = {}		local names = {}
	for _, field in ~~pairs~~(data.schema.fields) do		for _, field in ipairs(data.schema.fields) do
	table.insert(names, field.name)		table.insert(names, field.name)
	end		end
Line 102:		Line 102:
	local params = {}		local params = {}
	local paramOrder = {}		local paramOrder = {}
	for _, row in ~~pairs~~(data.data) do		for _, row in ipairs(data.data) do
	local newVal = {}		local newVal = {}
	local name = nil		local name = nil
	for pos, val in ~~pairs~~(row) do		for pos, val in ipairs(row) do
	local columnName = names[pos]		local columnName = names[pos]
	if columnName == 'name' then		if columnName == 'name' then

en>Johnuniq: Changed protection level for "Module:TNT": High-risk Lua module: per request at WP:RFPP to match Module:Excerpt ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2020-08-30T07:28:25Z

Changed protection level for "Module:TNT": High-risk Lua module: per request at WP:RFPP to match Module:Excerpt ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Older revision	Revision as of 03:28, 30 August 2020
(No difference)

en>Bawolff: Give a more useful error message if jsonconfig is missing. There have been three questions about this on the support desk from third party folks copying this template.

2019-11-27T11:15:52Z

Give a more useful error message if jsonconfig is missing. There have been three questions about this on the support desk from third party folks copying this template.

← Older revision		Revision as of 07:15, 27 November 2019
Line 153:		Line 153:
	if not dataset then		if not dataset then
	error(formatMessage(i18nDataset, 'error_no_dataset', {}))		error(formatMessage(i18nDataset, 'error_no_dataset', {}))
			end

			-- Give helpful error to thirdparties who try and copy this module.
			if not mw.ext or not mw.ext.data or not mw.ext.data.get then
			error('Missing JsonConfig extension; Cannot load https://commons.wikimedia.org/wiki/Data:' .. dataset)
	end		end

en>DannyS712: Protected "Module:TNT": Highly visible template ([Edit=Allow only autoconfirmed users] (indefinite) [Move=Allow only administrators] (indefinite))

2019-08-30T05:39:27Z

Protected "Module:TNT": Highly visible template ([Edit=Allow only autoconfirmed users] (indefinite) [Move=Allow only administrators] (indefinite))

← Older revision	Revision as of 01:39, 30 August 2019
(No difference)